docs: Deprecate Helm Operator - docs #5022
Open
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmihalac
changed the title
|
Can you re-trigger test ? @franciscojavierarceo |
|
done! that was strange though that test is usually not flaky... |
|
Also it is better to mention |
|
For now, we’re only deprecating the helm operatorOn Feb 7, 2025, at 9:26 AM, Theodor Mihalache ***@***.***> wrote:
@tmihalac commented on this pull request.
In docs/how-to-guides/running-feast-in-production.md:
@@ -203,7 +203,7 @@ feature_vector = fs.get_online_features(
).to_dict()
```
-### 4.2. Deploy Feast feature servers on Kubernetes
+### 4.2. Deploy Feast feature servers on Kubernetes (Deprecated replaced by [feast-operator](../../infra/feast-operator/README.md))
Are deprecating only the helm operator or everything that is related to helm like the feast server helm as well ?
@tchughesiv @franciscojavierarceo @redhatHameed
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
tchughesiv
requested changes
Feb 7, 2025
auto-merge was automatically disabled
February 7, 2025 19:50
Head branch was pushed to by a user without write access
|
OK reverted the chart deprecation tag |
…erver documentation (feast-dev#5019) Signed-off-by: Francisco Javier Arceo <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac
force-pushed
the
deprecate-feast-helm-operator-in-docs
branch
from
8f1880e to
8de4173
Compare
Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac
force-pushed
the
deprecate-feast-helm-operator-in-docs
branch
from
8de4173 to
b50e308
Compare
tchughesiv
requested changes
Feb 7, 2025
Comment on lines
+34
to
+41
| | Endpoint | Description | | ||
| |------------------------------|-------------------------------------------------------------------------| | ||
| | `/get-online-features` | Retrieves feature values for specified entities and feature references. | | ||
| | `/push` | Pushes feature data to the online and/or offline store. | | ||
| | `/materialize` | Materializes features within a specific time range to the online store. | | ||
| | `/materialize-incremental` | Incrementally materializes features up to the current timestamp. | | ||
| | `/retrieve-online-documents` | Supports Vector Similarity Search for RAG (Alpha end-ponit) | | ||
| | `/docs` | API Contract for available endpoints | |
There was a problem hiding this comment.
should these changes be in this PR? maybe a rebase is necessary?
| @@ -3,6 +3,7 @@ name: feast-feature-server | |||
| description: Feast Feature Server in Go or Python | |||
| type: application | |||
| version: 0.45.0 | |||
| deprecated: true | |||
There was a problem hiding this comment.
this line should be removed right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Helm Operator to point out that the operator is deprecated and the new feast go operator should be used instead.
What this PR does / why we need it:
The feast go operator is more powerful and allows a flexible deployment