Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate bieb in bloei #345

Merged
merged 15 commits into from
Jan 17, 2025

Conversation

Lmikkers
Copy link

What does this change?

Stekjes

  • #302 - H1 toegevoegd slug page
  • #279 - Stekjes: Responsive
  • #326 - Component verbetering toevoegen + Componenten gebruikt
  • #261 - Contrast verbeterd zaden + stekjes

Harry

  • #194 - Harry Responsive
  • #124- Uitgebreidere informatie Harry

Home

  • #301 - H2 cards titles responsive fix -> clamp ipv media queries

livesite

How Has This Been Tested?

  • User test
  • Performance test
  • Responsive Design test
  • Device test
  • Browser test -> Harry niet zichtbaar op Safari of andere verouderde browsers, hier gaan wij aan werken

Images

Detail verbetering stekjes

Before:

detail before

After:

detail after

Cards contrast verbetering

Before:

cards before

After:

cards after

Harry responsive

Stekjes pagina

Before

Scherm­afbeelding 2025-01-15 om 14 43 57

After

Scherm­afbeelding 2025-01-15 om 14 44 11

Home pagina

Before

Scherm­afbeelding 2025-01-15 om 14 48 03

After

Scherm­afbeelding 2025-01-15 om 14 49 08

How to review

  • Check Code Conventions
  • Test live preview
  • Test Mobile

rutgerkock and others added 14 commits January 13, 2025 15:09
fixed contrast + fixed layout + added hover
Ik heb ze opgedeeld in molecules en atoms, componenten. Ook heb ik het ontwerp verbeterd en de css beter gemaakt. #326
Ook heb ik een h1 toegevoegd aan de stekjes #302
Zaden detail verbetering toegevoegd + Scrollbar header gefixt + height cards h2 gefixt
We hebben de feedback die we hebben gekregen op onze PR verwerkt, ook hebben we paar issues opgepakt van de refactor en #336 en #310
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for biebinbloei-agency ready!

Name Link
🔨 Latest commit 3a26013
🔍 Latest deploy log https://app.netlify.com/sites/biebinbloei-agency/deploys/678a7379c7602b00096c7afc
😎 Deploy Preview https://deploy-preview-345--biebinbloei-agency.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for biebinbloei ready!

Name Link
🔨 Latest commit 3a26013
🔍 Latest deploy log https://app.netlify.com/sites/biebinbloei/deploys/678a7379e079d500084c15a0
😎 Deploy Preview https://deploy-preview-345--biebinbloei.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Annevd Annevd merged commit d50019e into release-candidate Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants