Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage responsive fixes #341

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

Annevd
Copy link

@Annevd Annevd commented Jan 16, 2025

What does this change?

Regards issue #301

  • height: 70vh veranderd naar min-height: 70vh. Dit is zodat wanneer er genoeg ruimte voor is, de sections inderdaad 70vh worden, maar zodra de content niet op 70vh zou passen dat dit niet afgesneden wordt.
  • Custom properties zijn toegevoegd voor consistente padding op sections
  • Uitgecommentaarde code is verwijderd
  • Onduidelijke comments duidelijker gemaakt
  • clamp toegevoegd aan de h2's

How Has This Been Tested?

  • User test
  • Accessibility test
  • Performance test
  • Responsive Design test
  • Device test
  • Browser test

Images

Before / Afters

  • Buurtcampus Oost introductie:

  • Partners:

  • Footer horizontaal gekanteld:

How to review

  • Device test
  • Responsive test desktop
  • Code conventies

Using custom properties. Also made sure to use min-height instead of height, so that text wont be cut off on different screen sizes.
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for biebinbloei-agency ready!

Name Link
🔨 Latest commit 8fd1c33
🔍 Latest deploy log https://app.netlify.com/sites/biebinbloei-agency/deploys/678922df8fc51f00086167a5
😎 Deploy Preview https://deploy-preview-341--biebinbloei-agency.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nazneen05x
Copy link
Collaborator

Hoi Anne, Je bent goed bezig! Hierbij de resultaten van je aanpassingen op mijn mobiel.

Over:

  • Heading fixen (clamp)

Agenda:

Partners

Verder moeten we even de contrast checken! Verder ziet het er goed uit!

@Nazneen05x
Copy link
Collaborator

Top!

@Nazneen05x Nazneen05x merged commit f9f75e8 into release-candidate Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants