Skip to content

Conversation

@mattock
Copy link

@mattock mattock commented Oct 21, 2015

These two commits fix various warnings reported by puppet-lint.

A lot more warnings were reported, but I did not fix them yet. For example:

  • Wrong indentation in resource / class definitions
  • Two-space soft tabs
  • Undocumented defines
  • Trailing whitespace

The indentation thing was the biggest complaint. Puppet-lint wants resources/classes to be called like this:

class { '::foo':
    param           => 'somevalue',
    long_param_name => 'somevalue',
}

In case the formatting gets messed up, the arrows are supposed to be aligned on top of each either.

If you want, I can fix most of the remaining warnings too and send another pull request.

Best regards,

Samuli

- Include classes by absolute name for Puppet 4 compatibility
- Single quote strigs which have no variables
- Change ::syslog_ng::config::content define's default value into undef

Signed-off-by: Samuli Seppänen <[email protected]>
Use of this parameter avoids the need to hardcode the syslog-ng config directory
path into external modules.

Signed-off-by: Samuli Seppänen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant