New Features about Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again)
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clayblockunova
changed the title
Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again)Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again)
|
what should I do now? does your work finished? |
|
should I rearrange those IE11 related features? |
|
what happened to the project? |
|
I'm sorry, I still need some time to look into this, as I don't have fresh Windows 7 and Windows 8 VMs for testing. |
is getting that very hard in Europe? |
|
when will your work finished? |
fasttime
reviewed
Nov 2, 2024
src/lib/definitions.js
Outdated
| useLocaleNumeralDefinition('ا', '"ar"', Infinity, 2, LOCALE_NUMERALS_IE11_WIN7_8); | ||
| useLocaleNumeralDefinition('ن', '"ar"', Infinity, 4, LOCALE_NUMERALS_IE11_WIN7_8); | ||
| useLocaleNumeralDefinition('ه', '"ar"', Infinity, 5, LOCALE_NUMERALS_IE11_WIN7_8); | ||
| useLocaleNumeralDefinition('ﺓ', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); |
There was a problem hiding this comment.
I'm getting a different character. Did you mean this one?
Suggested change
| useLocaleNumeralDefinition('ﺓ', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); | |
| useLocaleNumeralDefinition('ة', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8); |
|
anything else should I do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for create a PR about that the third time. What should I do about IE11 subversions?