This repository was archived by the owner on Nov 19, 2018. It is now read-only.
Reimplement codes using latest spaceship#29
Open
lacostej wants to merge 3 commits intofastlane-old:masterfrom
Open
Reimplement codes using latest spaceship#29lacostej wants to merge 3 commits intofastlane-old:masterfrom
lacostej wants to merge 3 commits intofastlane-old:masterfrom
Conversation
lib/codes/itunes_connect.rb
Outdated
| if format | ||
| output = download_format(codes, format, request_date, app) | ||
| else | ||
| output=codes.join("\n") |
There was a problem hiding this comment.
Surrounding space missing for operator =.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do we want to revive this ?
Given that the project is not yet ported to the monorepo ?