chore(benchmark): compare branches against the noise of the same code - #888
Draft
nigrosimone wants to merge 3 commits into
Draft
nigrosimone wants to merge 3 commits into
nigrosimone wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run bench:cmpbenchmarks one branch and then the other, and marks the rows that moved more than 5%. On a laptop the same code moves more than that between two runs (here a fixed CPU loop varied up to 2x), so which branch wins is a lottery.Now each benchmark runs in four workers, two on the other revision (A) and two on the working tree (B), that take turns in batches of about 10ms. A/A and B/B are the same code against itself and give the noise band of A/B: a row is faster or slower only outside the band, and by at least what is left of A/B. This is #886 against main on Node 26:
The five arrays #886 rewrites are faster, and 23 of the 24 rows where it writes the same code read noise. On Node 24, where it writes the same code everywhere, all 30 rows read noise.
bench:cmp:ci,cli-selectandsimple-gitare removed,npm run bench:cmp -- --against <ref>covers them.