Skip to content

chore(types): remove deprecated debugMode option - #840

Merged
metcoder95 merged 3 commits into
mainfrom
chore/remove-debugMode-deprecated
May 25, 2026
Merged

metcoder95 merged 3 commits into
mainfrom
chore/remove-debugMode-deprecated

Conversation

@Tony133

@Tony133 Tony133 commented May 17, 2026

Copy link
Copy Markdown
Member

Proposal:

Remove the deprecated debugMode boolean option in types/index.d.ts.

Changes:

  • Removed debugMode?: boolean from types/index.d.ts
  • Update index.js
  • Update debug-mode.test.js

Note:

@Tony133
Tony133 marked this pull request as ready for review May 17, 2026 14:45
@Tony133
Tony133 requested a review from a team May 17, 2026 14:52
@mcollina

Copy link
Copy Markdown
Member

is this present in the code?

@Tony133

Tony133 commented May 17, 2026

Copy link
Copy Markdown
Member Author

@mcollina

Copy link
Copy Markdown
Member

why then this is removed from the types?

@Tony133

Tony133 commented May 17, 2026

Copy link
Copy Markdown
Member Author

why then this is removed from the types?

Sorry, I didn't finish the first commit properly. The change is now complete. See the commit here: 5c0ef6f and 229f177 I didn't run git add in the terminal 😅

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95
metcoder95 merged commit a542bdc into main May 25, 2026
17 checks passed
@metcoder95
metcoder95 deleted the chore/remove-debugMode-deprecated branch May 25, 2026 09:33
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants