CPU (Linux): fix CPU detection on some PPC platforms #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some PowerPC devices (notably the Nintendo Wii and Nintendo Wii U), fastfetch detects the CPU incorrectly. It goes down the code path of 'detectSocName()', and actually matches the model of the device itself... as the CPU model name. This is obviously incorrect, and leads to reporting such as 'CPU: wii'. Disable this code path alltogether on PPC to prevent this, and just let it pull from cpuinfo. This lets it have correct CPU reporting, such as on the Wii, giving 'CPU: 750CL @ 0.73GHz'.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some PowerPC devices (notably the Nintendo Wii and Nintendo Wii U), fastfetch detects the CPU incorrectly. It goes down the code path of 'detectSocName()', and actually matches the model of the device itself... as the CPU model name. This is obviously incorrect, and leads to reporting such as 'CPU: wii'. Disable this code path alltogether on PPC to prevent this, and just let it pull from cpuinfo. This lets it have correct CPU reporting, such as on the Wii, giving 'CPU: 750CL @ 0.73GHz'.
I have confirmed that this does not cause any regressions in CPU detection on x86_64 (my PC), ARM (Raspberry Pi 4), and on other PPC devices (iBook G3).
There may be a more elegant way of doing this than disabling the codepath alltogether on PPC, but it didn't seem to have any useful reporing for PPC platforms in there anyways, so this is what I went with.