-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add option to set the width of the Rich exception output #528
base: master
Are you sure you want to change the base?
Conversation
📝 Docs preview for commit d82e751 at: https://63b9cedb2674445f42edea4e--typertiangolo.netlify.app |
📝 Docs preview for commit 36405da at: https://63dba78174f4db37545e5176--typertiangolo.netlify.app |
📝 Docs preview for commit 0e54ace at: https://63ef5180d07132579c80cd4c--typertiangolo.netlify.app |
📝 Docs preview for commit 7814341 at: https://64034f719f540d3ebc0ef662--typertiangolo.netlify.app |
78eb706
to
2587d6d
Compare
Hi @tiangolo , |
I definitely would like for this to be merged in! @tiangolo |
Yes, feature looks really good. @tiangolo Could you please, review? |
adding new attribute in DeveloperExceptionConfig to allow setting width for rick traceback.
add `pretty_exceptions_width` in typer class to be used by `DeveloperConfigException` to allow setting width of traceback boxes.
📝 Docs preview for commit 0460e47 at: https://293c1362.typertiangolo.pages.dev |
📝 Docs preview for commit 6d87cfd at: https://126b3831.typertiangolo.pages.dev |
📝 Docs preview for commit cb05984 at: https://e1850eae.typertiangolo.pages.dev |
📝 Docs preview for commit 45e9736 at: https://d38a79ef.typertiangolo.pages.dev |
📝 Docs preview for commit 1039c11 at: https://3bf4afed.typertiangolo.pages.dev Modified Pages |
Merging in the latest from [UPDATE]: fixed 🎉 |
📝 Docs preview for commit 96c0b5e at: https://e55605aa.typertiangolo.pages.dev Modified Pages |
If this is going to be added, it would be great if all options available to |
There's a recently merged PR that has conflicting behaviour for the setting of |
📝 Docs preview for commit fc4f3a6 at: https://631af5ac.typertiangolo.pages.dev Modified Pages |
📝 Docs preview for commit 5914d78 at: https://b6d86bdc.typertiangolo.pages.dev Modified Pages |
📝 Docs preview for commit 1c58bdf at: https://2bd66a0d.typertiangolo.pages.dev Modified Pages |
Ok, so there has been a related PR that was recently merged and that unifies the width of the Rich console for help and errors. On the new i.e. the error message takes up the full width of the console, which is already better than the original situation described here. Nonetheless, I still think it can be interesting to have this as a user-adjustable setting. So, I've merged the functionality from both PRs by setting the default of |
📝 Docs preview for commit 8872822 at: https://40948b56.typertiangolo.pages.dev Modified Pages |
📝 Docs preview for commit be51839 at: https://923b540a.typertiangolo.pages.dev Modified Pages |
add parameter as suggested feature in issue #523