Skip to content

Conversation

@svlandeg
Copy link
Member

@svlandeg svlandeg commented Nov 25, 2025

Follow-up of #1418, in which we started using Typer() explicitely throughout the documentation. That also means that the tests can simply access mod.app instead of having to redefine it.

Includes a bug fix originating from #1418 (marked as review comment)

@svlandeg svlandeg self-assigned this Nov 25, 2025
@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 25, 2025
return random.choice(["Deadpool", "Rick", "Morty", "Hiro"])


@app.command()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one (and in the next file) was a bug from #1418

@github-actions
Copy link
Contributor

@svlandeg svlandeg removed the docs Improvements or additions to documentation label Nov 25, 2025
@svlandeg svlandeg marked this pull request as ready for review November 25, 2025 15:06
@svlandeg svlandeg removed their assignment Nov 25, 2025
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is great! 🚀

@tiangolo tiangolo merged commit f7b240d into fastapi:master Nov 25, 2025
26 of 27 checks passed
@svlandeg svlandeg deleted the update/tests branch November 25, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants