Added code of milestone4 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvipash
suggested changes
Dec 4, 2019
Comment on lines
+153
to
+182
| boolean valid = true; | ||
| if (Utils.validateString(title)) { | ||
| titleField.setError(null); | ||
| } else { | ||
| titleField.setError(getString(R.string.title_error)); | ||
| valid = false; | ||
| } | ||
|
|
||
| if (Utils.validateString(place)) { | ||
| placeField.setError(null); | ||
| } else { | ||
| placeField.setError(getString(R.string.place_error)); | ||
| valid = false; | ||
| } | ||
|
|
||
| if (!date.isEmpty()) { | ||
| dateField.setError(null); | ||
| } else { | ||
| dateField.setError(getString(R.string.date_error)); | ||
| valid = false; | ||
| } | ||
|
|
||
| if (Utils.validatePrice(price)) { | ||
| priceField.setError(null); | ||
| } else { | ||
| priceField.setError(getString(R.string.price_error)); | ||
| valid = false; | ||
| } | ||
|
|
||
| return valid; |
There was a problem hiding this comment.
завеликий методи виходить, варто розбити на менші валідатори
Comment on lines
199
to
233
| private class UploadImageTask extends AsyncTask<Uri, Void, Void> { | ||
| protected void onPreExecute() { | ||
| progressBar.setVisibility(View.VISIBLE); | ||
| getWindow().setFlags(WindowManager.LayoutParams.FLAG_NOT_TOUCHABLE, | ||
| WindowManager.LayoutParams.FLAG_NOT_TOUCHABLE); | ||
| } | ||
|
|
||
| protected Void doInBackground(Uri... blobName) { | ||
| ServiceAccountCredentials credentials; | ||
| try { | ||
| credentials = ServiceAccountCredentials.fromStream(getResources().openRawResource(R.raw.bowlingsite)); | ||
| Storage storage = StorageOptions.newBuilder().setProjectId("bowlingsite") | ||
| .setCredentials(credentials) | ||
| .build() | ||
| .getService(); | ||
| final Bucket bucket = storage.get("www.bowling-iot.pp.ua"); | ||
| final String imgPath = "img/" + blobName[0].getLastPathSegment() + "." + getFileExtension(blobName[0]); | ||
| final BlobId blobId = BlobId.of(bucket.getName(), imgPath); | ||
| final InputStream imageStream = getContentResolver().openInputStream(blobName[0]); | ||
| final BlobInfo blobInfo = BlobInfo.newBuilder(blobId).setContentType("image/jpeg").build(); | ||
| final Blob blob = storage.create(blobInfo, imageStream); | ||
| imgDownloadLink = blob.getMediaLink(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| protected void onPostExecute(Void result) { | ||
| showImage(imgDownloadLink); | ||
| progressBar.setVisibility(View.INVISIBLE); | ||
| getWindow().clearFlags(WindowManager.LayoutParams.FLAG_NOT_TOUCHABLE); | ||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
трохи не розумію цілі винесення - цей клас використовує багато полів і методів класу в якому знаходиться і використання в його для інших класів не буде потрібно
Comment on lines
+95
to
+116
| if (!validate(title, place, date, price)) { | ||
| return; | ||
| } | ||
| final GoodsService service = getApplicationEx().getApiService(); | ||
| Good good = new Good(title, place, date, price, imgPath); | ||
| Call<Good> call = service.addGood(good); | ||
| progressBar.setVisibility(View.VISIBLE); | ||
| call.enqueue(new Callback<Good>() { | ||
| @Override | ||
| public void onResponse(Call<Good> call, Response<Good> response) { | ||
| progressBar.setVisibility(View.INVISIBLE); | ||
| if (response.isSuccessful()) { | ||
| openMainActivity(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Call<Good> call, Throwable t) { | ||
| progressBar.setVisibility(View.INVISIBLE); | ||
| Snackbar.make(findViewById(R.id.item_view), R.string.post_failed, Snackbar.LENGTH_LONG).show(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
цей метод троошки великий, треба подумати, якусь частину виокремити
Owner
Author
There was a problem hiding this comment.
чесно кажучи, не знайшла способу розділити цей метод. на мою думку 20 стрічок це не критично.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented posting of new goods and uploading images to them.