Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update ci actions and add dependabot #2096

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 9, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Update ci / add dependabot

/assign @jasondellaluce @leogr @LucaGuerra

Which issue(s) this PR fixes:

xref: falcosecurity/evolution#339

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Oct 9, 2024

Perf diff from master - unit tests

     6.17%     +0.90%  [.] sinsp::next
    11.07%     -0.87%  [.] sinsp_parser::reset
     0.40%     +0.83%  [.] scap_event_has_large_payload
     4.23%     +0.82%  [.] next
     0.28%     +0.58%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     0.83%     -0.55%  [.] std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, true> > >::_M_deallocate_nodes
     0.11%     +0.47%  [.] std::_Sp_counted_ptr_inplace<libsinsp::state::dynamic_struct::field_infos, std::allocator<libsinsp::state::dynamic_struct::field_infos>, (__gnu_cxx::_Lock_policy)2>::_M_destroy
     0.39%     +0.47%  [.] libsinsp::runc::match_container_id
     0.34%     +0.45%  [.] sinsp_parser::parse_clone_exit_child
     0.23%     +0.42%  [.] sinsp_evt::is_filtered_out

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0170         +0.0170           153           155           153           155
BM_sinsp_split_median                                          +0.0164         +0.0163           153           156           153           156
BM_sinsp_split_stddev                                          +0.1850         +0.1850             1             2             1             2
BM_sinsp_split_cv                                              +0.1652         +0.1652             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0450         -0.0450            63            60            63            60
BM_sinsp_concatenate_paths_relative_path_median                -0.0469         -0.0469            63            60            63            60
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5230         -0.5261             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5005         -0.5038             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0494         -0.0495            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0464         -0.0464            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6743         -0.6726             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6573         -0.6556             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0354         +0.0354            61            63            61            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.0470         +0.0469            61            63            61            63
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7864         -0.7862             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7937         -0.7935             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0241         +0.0241           396           405           396           405
BM_sinsp_split_container_image_median                          +0.0251         +0.0251           396           406           396           406
BM_sinsp_split_container_image_stddev                          -0.0840         -0.0843             3             3             3             3
BM_sinsp_split_container_image_cv                              -0.1056         -0.1059             0             0             0             0

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (3712714) to head (3c2af18).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2096   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31914    31914           
  Branches     5621     5612    -9     
=======================================
  Hits        23520    23520           
+ Misses       8392     8367   -25     
- Partials        2       27   +25     
Flag Coverage Δ
libsinsp 73.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @FedeDP

@poiana poiana added the lgtm label Oct 9, 2024
@poiana
Copy link
Contributor

poiana commented Oct 9, 2024

LGTM label has been added.

Git tree hash: 6f43b8c9632ad31ca0ce9ba626692704d73ab077

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
/approve

@poiana
Copy link
Contributor

poiana commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 9, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Oct 9, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 9, 2024
@poiana poiana merged commit e117af4 into falcosecurity:master Oct 9, 2024
49 checks passed
@FedeDP FedeDP changed the title Update ci chore(ci): update ci actions and add dependabot Oct 9, 2024
@cpanato cpanato deleted the update-ci branch October 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants