-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schema): make OPENAT2_E DIRFD_PARAM point to the right param #2084
Conversation
Signed-off-by: Grzegorz Nosek <[email protected]>
/milestone next-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 076484401690ab854f1485ce50b0c689e59da672
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
=======================================
Coverage 73.58% 73.58%
=======================================
Files 253 253
Lines 31869 31869
Branches 5654 5637 -17
=======================================
+ Hits 23451 23452 +1
+ Misses 8418 8408 -10
- Partials 0 9 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Instead of a const generic param that's not really possible to use (we don't have methods to access params by index), generate an actual method to get the dirfd corresponding to a PT_FSRELPATH from an event. The WIP part is manually patching the event schema for an upstream bug: falcosecurity/libs#2084
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area API-version
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
DIRFD_PARAM
is supposed to contain a reference to the corresponding dirfd parameter for a particular relative path param. For OPENAT2_E, the dirfd param refers back to thename
param, which is clearly wrong.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: