-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): avoid running drivers CI jobs that need secrets in PR coming from forks #2060
Conversation
… from forks. Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.18.0 |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 73.55% 73.55% -0.01%
==========================================
Files 253 253
Lines 31863 31863
Branches 5651 5632 -19
==========================================
- Hits 23438 23437 -1
+ Misses 8420 8400 -20
- Partials 5 26 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Well, we can eventually move to 0.19.0, this is not urgent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
The current solution is not working because
github.repository
resolves to the target github repository that is alwaysfalcosecurity/libs
.That trick is needed to avoid run a github action on forks.
Instead, we need to avoid running a github action on PRs coming from forks; we need to rely on
github.event.pull_request.head.repo.full_name
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: