-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): improve zh_CN vehicle manufacturers #3254
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3254 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2805 2805
Lines 217115 217129 +14
Branches 973 974 +1
==========================================
+ Hits 217030 217038 +8
- Misses 85 91 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pnpm run preflight
once and commit the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR and quick fixes ❤️ .
I checked with Google translate and it looks good to me, but I would love to have a native speaker review this as well.
It was my first pr so thanks for helping me correcting my mistake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the changes as well by using a translation program.
In the worst case (we don't find any native speaker), I'd say this is good enought and can be changed by later contributors if values are undesired.
Thanks for your contribution. ❤️ The changes will be included in the next release, but we don't a release schedule for it yet. |
Use the correct translations, and add some vehicle manufacturers to zh_CN