Blitzball Prize IDs

[Andrewki44]

Resolves #109

Raising as draft until entire prize index is mapped

[Andrewki44]

Ready for review.

ID's above 0x00C7 are unused
Appended ID to name due to multiple duplicates throughout the list.

[EvelynTSMG]

I'm going to assume the ids are correct; they're easy to update anyway.

Thank you! I just have a few suggestions :3

Don't implement the id suffix one immediately as @fkelava might disagree; we'd have to talk it out so it's best to wait a bit.

[EvelynTSMG]

As noted by Rurusachi over on Discord, these prize ids are not constant, but dynamic; the items they give differs based on the contents of takara.bin, etc.

For ids 0-99 (0-46):
call Common.obtainTreasure [015Bh](msgWindow=0 [00h], treasure=BlitzballLeaguePrizeIndex[priv10AAD4 - 1 [01h]] + 220 [DCh]);

For ids 101-199:

• if id - 100 < 31, (1 << (id - 100)) is compared against BlitzballPlayerLearnedTechsPage1
• else, (1 << (id - 100 - 30)) is compared against BlitzballPlayerLearnedTechsPage2

For id 286:
Common.displayFieldString [0064h](msgWindow=0 [00h], string="{TIME:00}Learned {VAR:00}!{\n}Player now able to learn extra techniques{\n}by expanding tech list slots!" [19h]);

For ids 287-289:

• 287 = Attack Reels
• 288 = Status Reels
• 289 = Aurochs Reels

In light of this, I think we should close this PR and the associated issue.

Update: The focus of this PR has shifted to account for this. It is now more than welcome.

[Andrewki44]

Refactored to utilize defined enums for techs & limits, and provide access functions to retrieve the relevant prize index value based on a treasure index (from takara.bin), tech or limit.

[EvelynTSMG]

I found some time to review this and Github's format helped me understand what was suggested in Discord.

I have some changes I'm suggesting, but nothing too big.
Also a question to @fkelava.

[EvelynTSMG]

Doesn't 0 -> 100 look nicer? 101 -> 160 isn't too bad and Wakka's overdrives are arbitrary either way.

[Andrewki44]

If this is the case, would you prefer the enums to be changed to decimal instead of hex as well?
I used hex here because I was also using that throughout the rest of the file/s, for consistency

[EvelynTSMG]

Sure. I'm frankly not sure you even need to specify the values for every variant, but continue to do so

[Andrewki44]

Review comments either resolved or replied to

[EvelynTSMG]

Two discussions remain unresolved:
#110 (comment)
#110 (comment)

[Andrewki44]

I was waiting for further feedback regarding decimal vs hex.
Especially as the review comment was only regarding a comment line as well, not the actual code.

[Andrewki44]

Discord discussion context provided for #110 (comment)

[EvelynTSMG]

This is fine.

Thank you for the contribution, take care 🩷