Support multiple box prompts in video inference - #615
Open
oValach wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sam3VideoInference.add_prompt()accepts box inputs with shapeN x 4, but the current video inference path requires an initial visual prompt to contain exactly one box.This change allows multiple initial box prompts to be packed into a single
Prompt, while preserving the existing single-box and refinement behavior.The multi-box representation uses the existing
Prompt.append_boxes()path also used by the multiplex video implementation.Motivation
Detector-driven video pipelines commonly produce multiple boxes for the same frame. With the current API, these boxes need to be submitted individually, which results in one single-frame inference call per box.
Supporting multiple boxes in one prompt allows all box prompts from a frame to be submitted together and processed in a single inference call.
Changes
Sam3VideoInference.Validation
Tested with: