Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relevant weights if not all contexts run equally #1408

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Relevant weights if not all contexts run equally #1408

wants to merge 2 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 30, 2022

When different contexts have been run a different number of times, then it's better to first aggregate by
settings. This is equivalent to the previous code if:

  • if all settings have been replicated the same number of times
  • asymptotically, if missing runs are equally distributed among different runs and we replicated sufficiently many times

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@teytaud
Relevant weights if not all contexts run equally
29a3c06 
When different contexts have been run a different number of times, then it's better to first aggregate by
settings. This is equivalent to the previous code if:
- if all settings have been replicated the same number of times
- asymptotically, if missing runs are equally distributed among different runs and we replicated sufficiently many times
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 30, 2022
@teytaud teytaud marked this pull request as draft March 30, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teytaud @facebook-github-bot