-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version of Heri's PR #1389
base: main
Are you sure you want to change the base?
new version of Heri's PR #1389
Conversation
Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Jérémy Rapin <[email protected]>
Co-authored-by: Jérémy Rapin <[email protected]>
…ergrad into coolheri
@herilalaina I would be sad if this was never finished so I did this :-) |
.circleci/config.yml
Outdated
pip install --progress-bar off -U pip setuptools | ||
pip install --progress-bar off -U auto-sklearn>=0.14.0 openml>=0.12.2 submitit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not in bench.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-/ no idea. Let me try.
seedg = create_seed_generator(seed) | ||
|
||
# Only considered small subset of OpenML-CC18 | ||
list_tasks = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to generate this automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here without @herilalaina it's difficult to answer :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These task IDs are manually picked, representing only small datasets. The complete benchmarking set includes 72 datasets, which IMO will be computationally prohibitive.
nevergrad/functions/automl/core.py
Outdated
random_state: tp.Optional[int] = None, | ||
) -> None: | ||
|
||
if os.name != "nt": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do the opposite, if os.name == "nt" then raise
then no need of indent anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
@jrapin not sure if Heri can be back and answer some of your questions... I do my best for parts for which I know what to do. |
Groumpf I believe it was just fine now but baoum! a big static analysis issue. No idea what is causing this. |
I guess we must stay at mypy 0.931 for the moment as more recent versions fail. |
Changing to 0.931 does not fix it @#$%&^@ |
Thank you very much for taking this up!
I also encountered such a conflict of versions on my own. @jrapin would it make sense to run the evaluation part of the code on a separate container (e.g. Singularity) as in HPOBench ? |
Types of changes
Motivation and Context / Related issue
Original PR looks dead: #1060
How Has This Been Tested (if it applies)
Checklist