Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of Heri's PR #1389

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

new version of Heri's PR #1389

wants to merge 46 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 15, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Original PR looks dead: #1060

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 15, 2022
@teytaud teytaud mentioned this pull request Mar 15, 2022
5 tasks
@teytaud teytaud requested a review from jrapin March 15, 2022 16:01
@teytaud
Copy link
Contributor Author

teytaud commented Mar 15, 2022

@herilalaina I would be sad if this was never finished so I did this :-)

pip install --progress-bar off -U pip setuptools
pip install --progress-bar off -U auto-sklearn>=0.14.0 openml>=0.12.2 submitit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in bench.txt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-/ no idea. Let me try.

seedg = create_seed_generator(seed)

# Only considered small subset of OpenML-CC18
list_tasks = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to generate this automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here without @herilalaina it's difficult to answer :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These task IDs are manually picked, representing only small datasets. The complete benchmarking set includes 72 datasets, which IMO will be computationally prohibitive.

random_state: tp.Optional[int] = None,
) -> None:

if os.name != "nt":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the opposite, if os.name == "nt" then raise
then no need of indent anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@teytaud
Copy link
Contributor Author

teytaud commented Mar 15, 2022

@jrapin not sure if Heri can be back and answer some of your questions... I do my best for parts for which I know what to do.

@teytaud
Copy link
Contributor Author

teytaud commented Mar 16, 2022

Groumpf I believe it was just fine now but baoum! a big static analysis issue. No idea what is causing this.

@teytaud
Copy link
Contributor Author

teytaud commented Mar 17, 2022

Groumpf I believe it was just fine now but baoum! a big static analysis issue. No idea what is causing this.

I guess we must stay at mypy 0.931 for the moment as more recent versions fail.

@teytaud
Copy link
Contributor Author

teytaud commented Mar 17, 2022

Groumpf I believe it was just fine now but baoum! a big static analysis issue. No idea what is causing this.

I guess we must stay at mypy 0.931 for the moment as more recent versions fail.

Changing to 0.931 does not fix it @#$%&^@

@herilalaina
Copy link
Contributor

@herilalaina I would be sad if this was never finished so I did this :-)

Thank you very much for taking this up!

I guess we must stay at mypy 0.931 for the moment as more recent versions fail.

I also encountered such a conflict of versions on my own. @jrapin would it make sense to run the evaluation part of the code on a separate container (e.g. Singularity) as in HPOBench ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants