Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Python Crop Simulation #1339

Open
wants to merge 204 commits into
base: main
Choose a base branch
from
Open

Adding Python Crop Simulation #1339

wants to merge 204 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Jan 20, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Crop is a fundamental problem for humans on this planet.
I've not used the full power of PCSE --- more to come.

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 20, 2022
@teytaud teytaud requested a review from jrapin January 20, 2022 16:54
@teytaud teytaud mentioned this pull request Jan 21, 2022
Closed
jrapin
jrapin requested changes Jan 26, 2022
View reviewed changes
nevergrad/functions/pcse/pcse.py Show resolved Hide resolved
nevergrad/functions/pcse/pcse.py
Comment on lines +21 to +22
import yaml
import pandas as pd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard imports should be on top, pcse can be kept inline to avoid issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard imports should be on top, pcse can be kept inline to avoid issues

Done.

nevergrad/functions/pcse/pcse.py Outdated
# error = objfunc_calculator(defaults)
# print("Objective function value with default parameters (%s): %s" % (defaults, error))

import nevergrad as ng
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on top

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

nevergrad/functions/pcse/test_pcse.py Outdated Show resolved Hide resolved
nevergrad/optimization/optimizerlib.py Outdated Show resolved Hide resolved
nevergrad/optimization/test_optimizerlib.py Outdated Show resolved Hide resolved
@jrapin
Copy link
Contributor

jrapin commented Jan 26, 2022

I guess the License is too restrictive here :s it's a bit borderline here since it's a benchmark and not an optimizer, but it safer to avoid adding any...

@teytaud
Copy link
Contributor Author

teytaud commented Feb 16, 2022

I guess the License is too restrictive here :s it's a bit borderline here since it's a benchmark and not an optimizer, but it safer to avoid adding any...

Would a wget in the code be ok ?

teytaud and others added 30 commits December 12, 2022 19:40
@teytaud
nlopt
e56d4e2
@teytaud
nlopt
19cbc13
@teytaud
fix
abb9ae3
@teytaud
fix
d3b97ce
@teytaud
fix
9299e19
@teytaud
po
5480d31
@teytaud
Update experiments.py
d849756
@teytaud @jrapin
Update nevergrad/optimization/optimizerlib.py
98b6c5f 
Co-authored-by: Jérémy Rapin <[email protected]>
@teytaud
Update test_pcse.py
7b4dca7
@teytaud
Update experiments.py
ed9c32a
@teytaud
Pcse2: irrigation challenge (#1341)
292fdc1 
* irrigation_challenge

* flute

* fix

* Update __init__.py

* Update experiments.py

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix_gym

* fix_gym

* fix_gym

* fix

* fix
@teytaud
fix
a389d2f
@teytaud
fix
5b3627d
@teytaud
dependencies
c760aae
@teytaud
black
1d1cb80
@teytaud
fix
6389f6b
@teytaud
fix
0a4840d
@teytaud
Update pcse.py
6a6b2a9
@teytaud
pcse
a1243ee
@teytaud
fix
5e34325
@teytaud
pcse
acd792f
@teytaud
ZZfix
e293dfc
@teytaud
nlopt
946f5ca
@teytaud
ZZnlopt
c2bc52d
@teytaud
ZZPcse2: irrigation challenge (#1341)
cdb657b 
* irrigation_challenge

* flute

* fix

* Update __init__.py

* Update experiments.py

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix_gym

* fix_gym

* fix_gym

* fix

* fix
@teytaud
pcse
25e8681
@teytaud
benin
e23551d
@teytaud
Optimizing simultaneously variety, irrigation and crop (#1467)
adf3f31 
* fix

* Adding costs in dollars per kg for various crops, and weird operations by Lev distance (#1468)

* fix

* Support for choosing the year(s) in PCSE stuff (#1469)

* fix

* o

* fix
@teytaud
Superpcse (#1484)
d37da25 
* fix

* fix

* fix

* o

* fix

* fix

* fix

* fix

* GZZfix

* fix

* black

* fix_tst_irrigation

* one_more_false
@teytaud
fix
750f908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrapin jrapin jrapin requested changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@teytaud @jrapin @facebook-github-bot @Game4Move78 @AnMoreau