Skip to content

Conversation

mdouze
Copy link
Contributor

@mdouze mdouze commented Apr 15, 2025

Summary: Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185

mdouze and others added 6 commits April 13, 2025 14:41
Differential Revision: D72937710
Differential Revision: D72937708
Differential Revision: D72937711
Differential Revision: D72937709
…training code, split quantizer code into headers, Make headers more independent

Summary:
Move the interface of SIMD functions to use the simdXfloat32 API to mutualize code.
Begin splitting the ScalarQuantizer.cpp
Continue splitting. Purely in header files for now.

Differential Revision: D72945865
Summary: Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73037185

@alexanderguzhva
Copy link
Contributor

alexanderguzhva commented Apr 21, 2025

https://github.com/facebookresearch/faiss/pull/4296/files#diff-6b8e2e1bd2570626453d39cccd202853ebf5306d63aa04bf0ab5ed1d4ab54e9c should not be included
Same with the other .o and .out files

@alexanderguzhva
Copy link
Contributor

alexanderguzhva commented Apr 21, 2025

it is worth having an API that controls SIMDConfig::level at the runtime, at least to evaluate and compare the performance of various SIMD implementations in benchmarks

mdouze added a commit to mdouze/faiss that referenced this pull request Apr 24, 2025
)

Summary:
Pull Request resolved: facebookresearch#4296

Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
@mdouze
Copy link
Contributor Author

mdouze commented Apr 24, 2025

superseded by #4309

@mdouze mdouze closed this Apr 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73037185

mdouze added a commit to mdouze/faiss that referenced this pull request May 5, 2025
)

Summary:
Pull Request resolved: facebookresearch#4296

Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
mdouze added a commit to mdouze/faiss that referenced this pull request May 6, 2025
)

Summary:
Pull Request resolved: facebookresearch#4296

Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
algoriddle pushed a commit to algoriddle/faiss that referenced this pull request May 7, 2025
)

Summary:
Pull Request resolved: facebookresearch#4296

Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73037185

mdouze added a commit to mdouze/faiss that referenced this pull request Jun 4, 2025
)

Summary:
Pull Request resolved: facebookresearch#4296

Splits the ScalarQuantizer code into parts so that the AVX2 and AVX512 can be compiled independently.

Differential Revision: D73037185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants