Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle max_num_warnings properly #1089

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zyaoj
Copy link
Contributor

@zyaoj zyaoj commented Mar 19, 2025

What does this PR do? Please describe:

The max_num_warnings tests have been skipped and it does not function as expected.

Does your PR introduce any breaking changes? If yes, please list them:

N/A

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

Sorry, something went wrong.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
zyaoj added 4 commits March 19, 2025 14:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ebookresearch/fairseq1 into zyaoj/data-pipeline-max-num-warnings
@zyaoj zyaoj changed the title test Handle max_num_warnings properly Mar 19, 2025
zyaoj added 3 commits March 19, 2025 15:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants