Non-deterministic map operator option in data loading #1088
+378
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cbalioglu
approved these changes
Mar 26, 2025
|
|
||
| namespace fairseq2n::detail { | ||
|
|
||
| class thread_pool { |
There was a problem hiding this comment.
I think it is okay for the time-being, but note that this will clash with TBB's thread pool similar to how it clashes with OpenMP and MKL. Ideally we should leverage TBB here instead of writing our own pool implementation.
| std::atomic<bool> finished_{false}; | ||
| std::atomic<size_t> tasks_in_flight_{0}; | ||
| std::exception_ptr exception_ptr_{}; | ||
| // TODO: Use this conditionally on FAIRSEQ2N_USE_TBB instead: tbb::task_arena pool_; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
Add the "deterministic" boolean parameter to the map operator in data_pipeline. It follows similar semantics as the tensorflow equivalent: https://www.tensorflow.org/api_docs/python/tf/data/Dataset#map , i.e. it trades the matching of output and input order with some execution speed.
Does your PR introduce any breaking changes? If yes, please list them:
No
Check list: