This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Remove redundant rescaling in feature extraction #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi guys and thank you for your amazing code, I noticed that you are scaling the feature vector before normalizing it which is equivalent to simply normalize it.
facebook-github-bot
added
the
CLA Signed
|
I guess it's even better to avoid normalizing because original vectors are not normalized |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys and thank you for your amazing code,
I noticed that you are scaling the feature vector before normalizing it which is equivalent to simply normalize it.