Skip to content

patch: Declared the later dependency for test support #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

neuralsorcerer
Copy link
Contributor

Change:

  • Declared the later dependency for test support in pyproject.toml file.

Why this change?

  • Tests failing due to ModuleNotFoundError

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2025
@facebook-github-bot
Copy link
Contributor

@rodrigodesalvobraz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@rodrigodesalvobraz
Copy link
Contributor

Thanks for the patch! Not sure why this is causing a Codecov failure. I won't be able to look into this right now. Any idea of what may be causing that?

@neuralsorcerer
Copy link
Contributor Author

image
Seems it couldn't find pearl.test package. I believe we can fix this by including the root test directory in this package's module search path.
Let me fix this up quick and update this PR.

@rodrigodesalvobraz
Copy link
Contributor

rodrigodesalvobraz commented Jun 25, 2025

Hard to see that would be the reason. pearl.test has been there forever without a problem until now, and it's still working in the other platforms...

@neuralsorcerer
Copy link
Contributor Author

Hard to see that would be the reason. pearl.test has been there forever without a problem until now, and it's still working in the other platforms...

Ahh that's true, maybe I'm missing something here. Sorry, my bad 🥲

@neuralsorcerer neuralsorcerer marked this pull request as draft June 25, 2025 17:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e9a0467). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage        ?   83.41%           
=======================================
  Files           ?      185           
  Lines           ?     9462           
  Branches        ?        0           
=======================================
  Hits            ?     7893           
  Misses          ?     1569           
  Partials        ?        0           
Flag Coverage Δ
unittests 83.41% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neuralsorcerer neuralsorcerer marked this pull request as ready for review June 25, 2025 19:47
@neuralsorcerer
Copy link
Contributor Author

Hi @rodrigodesalvobraz,

As you kindly pointed out, the pearl.test structure has indeed been stable and has continued to work across other platforms without issue.

That said, this workaround is the only approach that seems to resolve the issue on my end for now. I’d truly appreciate your thoughts on whether this could be considered a safe and sustainable solution moving forward.

Also, apologies if I’ve overlooked something obvious here 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants