Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cmake): Fix remote function benchmark #12038

Closed
wants to merge 1 commit into from
Closed

build(cmake): Fix remote function benchmark #12038

wants to merge 1 commit into from

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Jan 8, 2025 •
edited
Loading

This patch added the missing utf8 lib dependency for remote function benchmark
Signed-off-by: Yuan Zhou [email protected]

Fixes: #12039

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 395f2e7
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/678911c8a6f0f800087e3543

@zhouyuan zhouyuan changed the title Fix(benchmark): Fix remote function benchmark fix(benchmark): Fix remote function benchmark Jan 8, 2025
@majetideepak
Copy link
Collaborator

@zhouyuan CI is failing. Looks like a typo in the library name?

@zhouyuan zhouyuan force-pushed the wip_fix_remote_function_benchmark branch from 88afdce to 6175998 Compare January 8, 2025 23:28
@zhouyuan
Copy link
Contributor Author

zhouyuan commented Jan 9, 2025

@majetideepak Thank you for the check. I just fixed the spell and the CI is passing now.

thanks, -yuan

@assignUser assignUser changed the title fix(benchmark): Fix remote function benchmark build(cmake): Fix remote function benchmark Jan 9, 2025
@assignUser
Copy link
Collaborator

I corrected the title because fix: equals a bump in patch version, which isn't really the case here :)

@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 9, 2025
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhouyuan
Copy link
Contributor Author

Hi @Yuhta could you please share the error reported in Facebook Internal CI?

Thanks, -yuan

@majetideepak
Copy link
Collaborator

@zhouyuan can you please rebase this PR with the latest master?
@kagamiori can then help merge this.

@zhouyuan
Fix(benchmark): Fix remote function benchmark
395f2e7 
This patch addes the missing utf8 lib for remote function benchmark
Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan zhouyuan force-pushed the wip_fix_remote_function_benchmark branch from 6175998 to 395f2e7 Compare January 16, 2025 14:03
@zhouyuan
Copy link
Contributor Author

Hi @majetideepak @kagamiori Sure, just rebased. Please help to take a look.

Thanks, -yuan

@facebook-github-bot
Copy link
Contributor

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kagamiori merged this pull request in 17e5935.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak majetideepak approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to build velox_benchmark_local_remote_comparison
4 participants
@zhouyuan @majetideepak @assignUser @facebook-github-bot