build: Set up nightly runs of table evolution fuzzer #12037
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67921566 |
✅ Deploy Preview for meta-velox canceled.
|
assignUser
reviewed
Jan 8, 2025
| @@ -202,6 +202,7 @@ jobs: | |||
| run: | | |||
| EXTRA_CMAKE_FLAGS="-DPYTHON_EXECUTABLE=$(which python3) $EXTRA_CMAKE_FLAGS" | |||
| make debug | |||
| make release | |||
There was a problem hiding this comment.
Why? We run all other fuzzers debug only.
There was a problem hiding this comment.
Release build runs faster and could cover more cases, we probably should run all fuzzers in release build
There was a problem hiding this comment.
Release makes sense, I would be fine with either or but running both seems redundant.
Also should we use release with debug symbols for better stacktraces or do the fuzzers have their own thing?
There was a problem hiding this comment.
Yeah we should include the full symbol in these builds for fuzzers
…or#12037) Summary: Pull Request resolved: facebookincubator#12037 Differential Revision: D67921566
kagamiori
force-pushed
the
export-D67921566
branch
from
4ef3eaf to
ed4af9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67921566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D67921566