refactor(dwio): Rewrite partition file path unescape utility functions using folly::uriUnescape() #12036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
✅ Deploy Preview for meta-velox canceled.
|
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 7, 2025
Summary: To troubleshoot an unreproducable hex string unescape error in prod: https://fburl.com/scuba/xldb_koski_queries/1o0x05d8 ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
8b2739f to
96ea958
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 7, 2025
…kincubator#12036) Summary: To troubleshoot an unreproducable hex string unescape error in prod: https://fburl.com/scuba/xldb_koski_queries/1o0x05d8 ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
96ea958 to
8e39743
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 7, 2025
…kincubator#12036) Summary: To troubleshoot an unreproducable hex string unescape error in prod: https://fburl.com/scuba/xldb_koski_queries/1o0x05d8 ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
8e39743 to
29bc912
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
force-pushed
the
export-D67917130
branch
from
29bc912 to
084a464
Compare
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 8, 2025
…unctions using folly::uriEscape() (facebookincubator#12036) Summary: Refactor the uri escape/unescape utility function to solve an unreproducable hex string unescape error in prod: https://fburl.com/scuba/xldb_koski_queries/1o0x05d8 ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 8, 2025
…unctions using folly::uriEscape() (facebookincubator#12036) Summary: Pull Request resolved: facebookincubator#12036 Refactor the uri escape/unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
084a464 to
19b412c
Compare
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 8, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
19b412c to
d8e8d0c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 8, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Pull Request resolved: facebookincubator#12036 Refactor the uri unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
d8e8d0c to
59c3e80
Compare
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 8, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
59c3e80 to
3b29e6c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 9, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
3b29e6c to
f3ac5b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
darrenfu
changed the title
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 9, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function using folly::uriUnescape NOTE: UriEscape refactor is not part of this PR due to its underlying escape char set is only a subset of folly::uriEscape's char set causing slightly behavior discrepancy ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
added a commit
to darrenfu/velox
that referenced
this pull request
Jan 9, 2025
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function to solve an unreproducable hex string unescape error in prod ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` Reviewed By: spershin Differential Revision: D67917130
darrenfu
force-pushed
the
export-D67917130
branch
from
c46432e to
0cbe8a5
Compare
|
@darrenfu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…s using folly::uriUnescape() (facebookincubator#12036) Summary: Refactor the uri unescape utility function using folly:: uriUnescape NOTE: UriEscape refactor is not part of this PR due to its underlying escape char set is only a subset of folly::uriEscape's char set causing slightly behavior discrepancy Test Plan: ``` buck test //velox/dwio/catalog/fbhive/test:file-utils-tests ``` ## Koski error events before the change ``` Expression: (*__errno_location ()) != 34 && end == tmp.data() + HEX_WIDTH Function: unescapePathName File: fbcode/velox/dwio/catalog/fbhive/FileUtils.cpp Line: 154 ``` https://fburl.com/scuba/xldb_koski_queries/c9z0941x Reviewed By: spershin Differential Revision: D67917130 Pulled By: darrenfu
darrenfu
force-pushed
the
export-D67917130
branch
from
0cbe8a5 to
816a542
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67917130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor the uri unescape utility function using folly:: uriUnescape
NOTE: UriEscape refactor is not part of this PR due to its underlying escape
char set is only a subset of folly::uriEscape's char set causing slightly
behavior discrepancy
Differential Revision: D67917130