feat(fuzzer): Add custom special form signatures for Presto and Spark #12032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
rui-mo
changed the title
|
Hi @kagamiori, would you like to take a review on this fuzzer change? Thanks! |
rui-mo
changed the title
rui-mo
changed the title
kagamiori
approved these changes
Jan 10, 2025
| @@ -34,6 +35,7 @@ using facebook::velox::exec::test::ExprTransformer; | |||
| /// FuzzerRunner leverages ExpressionFuzzerVerifier to create a gtest unit test. | |||
| class FuzzerRunner { | |||
| public: | |||
| // @param signatureGenerator Generates valid signatures for special forms. | |||
There was a problem hiding this comment.
nit: use /// instead of //
|
|
||
| // @param signatureGenerator Generates valid signatures for special forms. |
|
|
||
| std::vector<exec::FunctionSignaturePtr> | ||
| SparkSpecialFormSignatureGenerator::getSignaturesForConcatWs() const { | ||
| return {// Signature: concat_ws (separator, input, ...) -> output: |
There was a problem hiding this comment.
nit: Put comment in an separate line.
|
|
||
| std::vector<exec::FunctionSignaturePtr> | ||
| SpecialFormSignatureGenerator::getSignaturesForAnd() const { | ||
| return {// Signature: and (condition,...) -> output: |
| public: | ||
| virtual ~SpecialFormSignatureGenerator() {} | ||
|
|
||
| /// Generates valid signatures for special forms and append to the signature |
There was a problem hiding this comment.
nit: Generates valid signatures for the specified special forms and append them to the signature map. specialForms specifies a list of special form names delimited by comma.
|
|
||
| protected: | ||
| /// Generates signatures for cast from integral types to the given type and | ||
| /// adds to input vector. |
There was a problem hiding this comment.
nit: ... and add them to signatures? Same for the other comments below.
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 8817013. |
|
@kagamiori Thanks for helping review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signatures of special forms used in the expression fuzzer are different
between Presto and Spark. This PR adds 'SpecialFormSignatureGenerator' and
'SparkSpecialFormSignatureGenerator' for Presto and Spark respectively. Custom
signatures for Spark cast and concat_ws function were added.