refactor(cache): Clean up redundant code #12024
Open
+68
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
✅ Deploy Preview for meta-velox canceled.
|
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 6, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
a0bd3c2 to
ca90133
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
kewang1024
reviewed
Jan 7, 2025
| DEFINE_METRIC( | ||
| kMetricSsdCacheDeleteCheckpointErrors, facebook::velox::StatType::SUM); | ||
| kMetricSsdCacheDeleteFileErrors, facebook::velox::StatType::SUM); |
There was a problem hiding this comment.
the naming seems confusing, since it only include two types and doesn't have SSD file?
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
ca90133 to
4ea1cd5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor read checkpoint code and consolidate duplicate file clean up.
Differential Revision: D67868731