Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support UNKNOWN type for Spark collect_set aggregate function #12013

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

WangGuangxin
Copy link

@WangGuangxin WangGuangxin commented Jan 3, 2025

Gluten maps Spark NullType as UNKNOWN type in Velox. This PR supports the
UNKNOWN type for the Spark collect_set aggregate function.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b6ba8b2
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/677f66119fc98d0008ba9f58

@WangGuangxin
Copy link
Author

@zhli1142015 @rui-mo Could you please help review this?

Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jan 8, 2025

@WangGuangxin, please revise the title to replace "null type" with "UNKNOWN type", since null type is not belonging to velox.

@WangGuangxin WangGuangxin changed the title feat: Support null type for SparkSQL's collect_set feat: Support UNKNOWN type for SparkSQL's collect_set Jan 8, 2025
@WangGuangxin
Copy link
Author

@WangGuangxin, please revise the title to replace "null type" with "UNKNOWN type", since null type is not belonging to velox.

Thanks, fixed

@rui-mo rui-mo changed the title feat: Support UNKNOWN type for SparkSQL's collect_set feat: Support UNKNOWN type for Spark collect_set aggregate function Jan 8, 2025
@@ -260,5 +260,23 @@ TEST_F(CollectSetAggregateTest, rowWithNestedNull) {
{data}, {}, {"collect_set(c0)"}, {"spark_array_sort(a0)"}, {expected});
}

TEST_F(CollectSetAggregateTest, nullType) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: nullType->unknownType

Copy link
Contributor

@zhli1142015 zhli1142015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rui-mo
Copy link
Collaborator

rui-mo commented Jan 9, 2025

@WangGuangxin Could you rebase this PR to get rid of the fuzzer failure?

@WangGuangxin
Copy link
Author

@WangGuangxin Could you rebase this PR to get rid of the fuzzer failure?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants