Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Compression file check output #12009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkhaliqi
Copy link
Contributor

@jkhaliqi jkhaliqi commented Jan 3, 2025

fixes: #11657

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b962a67
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/677da8813352bd000847b5b5

@jkhaliqi jkhaliqi changed the title fix:Fix check output in Compression.cpp fix:Fix DWIO_ENSURE check output Jan 3, 2025
@jkhaliqi jkhaliqi changed the title fix:Fix DWIO_ENSURE check output fix:Fix Compression file check output Jan 3, 2025
@jkhaliqi jkhaliqi changed the title fix:Fix Compression file check output Fix:Fix Compression file check output Jan 3, 2025
@jkhaliqi jkhaliqi changed the title Fix:Fix Compression file check output fix: Fix Compression file check output Jan 3, 2025
@jkhaliqi jkhaliqi force-pushed the jk_dwio_ensure branch 2 times, most recently from f95ea89 to b4a6a93 Compare January 3, 2025 17:36
@prestodb-ci
Copy link

@ethanyzhang imported this issue into IBM GitHub Enterprise

"{} decompression failed, input len is too small: {}",
kind_,
compressedSize);
fmt::format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: plz add fmt header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dwio/common/compression/Compression.cpp DWIO_ENSURE_LE check output NOT as expected
4 participants