-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Compression file check output #12009
Open
jkhaliqi
wants to merge
1
commit into
facebookincubator:main
Choose a base branch
from
jkhaliqi:jk_dwio_ensure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 3, 2025
✅ Deploy Preview for meta-velox canceled.
|
jkhaliqi
changed the title
fix:Fix check output in Compression.cpp
fix:Fix DWIO_ENSURE check output
Jan 3, 2025
jkhaliqi
force-pushed
the
jk_dwio_ensure
branch
from
January 3, 2025 00:59
52eb691
to
b63b301
Compare
jkhaliqi
changed the title
fix:Fix DWIO_ENSURE check output
fix:Fix Compression file check output
Jan 3, 2025
jkhaliqi
changed the title
fix:Fix Compression file check output
Fix:Fix Compression file check output
Jan 3, 2025
jkhaliqi
changed the title
Fix:Fix Compression file check output
fix: Fix Compression file check output
Jan 3, 2025
jkhaliqi
force-pushed
the
jk_dwio_ensure
branch
2 times, most recently
from
January 3, 2025 17:36
f95ea89
to
b4a6a93
Compare
@ethanyzhang imported this issue into IBM GitHub Enterprise |
jkhaliqi
force-pushed
the
jk_dwio_ensure
branch
from
January 7, 2025 21:27
b4a6a93
to
0ad778b
Compare
zuyu
reviewed
Jan 7, 2025
"{} decompression failed, input len is too small: {}", | ||
kind_, | ||
compressedSize); | ||
fmt::format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: plz add fmt
header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in thank you!
jkhaliqi
force-pushed
the
jk_dwio_ensure
branch
from
January 7, 2025 22:19
0ad778b
to
b962a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11657