feat: Add Spark to_json function #11995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
CC @rui-mo |
rui-mo
reviewed
Jan 8, 2025
velox/docs/functions/spark/json.rst
Outdated
| @@ -44,3 +44,14 @@ JSON Functions | |||
| SELECT json_object_keys(''); -- NULL | |||
| SELECT json_object_keys(1); -- NULL | |||
| SELECT json_object_keys('"hello"'); -- NULL | |||
|
|
|||
| .. spark:function:: to_json(json_object) -> jsonString | |||
There was a problem hiding this comment.
nit: use camel-case naming style for 'json_object'.
|
|
||
| namespace facebook::velox::functions::sparksql { | ||
|
|
||
| class ToJsonCallToSpecialForm : public exec::FunctionCallToSpecialForm { |
There was a problem hiding this comment.
Since the result type is determined (varchar), we might don't need to implement 'to_json' as a special form. Special form is only used for the functions whose result type cannot be inferred from input type. For this case, we can implement it as a simple function.
More information on simple functions: https://github.com/facebookincubator/velox/blob/main/velox/docs/develop/scalar-functions.rst.
There was a problem hiding this comment.
Remove the special form, pls take a look again.
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Spark
to_jsonfunction: https://docs.databricks.com/en/sql/language-manual/functions/to_json.html