-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): upgrade all dependencies and migrate as required #50
base: main
Are you sure you want to change the base?
feat(deps): upgrade all dependencies and migrate as required #50
Conversation
Hi @LeoniePhiline! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Migration was applied, adapting `fastmod` to `rprompt` API changes: <https://github.com/conradkleinespel/rprompt/releases/tag/v2.0.2>
d574195
to
09dea5f
Compare
This changeset migrates `fastmod` from clap 2.x to the latest clap 4.x, migrating code around breaking changes. The arguments setup and retrieval is migrated to clap's much more maintainable `derive` syntax. All arguments are migrated to function identically to their clap 2 counterparts.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
6bc7096
to
948e996
Compare
--fancy
mode, supporting lookarounds
--fancy
mode, supporting lookarounds
This PR is meant as base for implementing opt-in If you can find time at all, I would very much appreciate if you could review this PR, and optionally cut a release (0.5.0). All changes are logically grouped into individual commits and should be rather simple to review. Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay; just now getting to my task backlog thanks to the impending holiday. In the future, using the GitHub request review feature on the PR. will give things a better chance of getting noticed.
let (maybe_escaped_regex, subst) = if matches.is_present("fixed_strings") { | ||
(regex::escape(regex_str), subst.replace("$", "$$")) | ||
|
||
let file_set = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, inlining this function does not make the code better. Why do we need to do it?
|
||
/// Regular expression to match. | ||
#[arg(value_name = "REGEX")] | ||
r#match: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a #
in the middle of this identifier?
I have signed the individual CLA.
I am working on an implementation of #49.
In preparation, dependencies need to be brought up to date.
chore(deps): update transitive dependencies
This changeset updates transitive dependencies, while keeping
Cargo.toml
untouched.fix(deps): upgrade assert_cmd to 2
Migrate
assert_cmd
from version 1 to 2. No relevant breaking changes.fix(deps): upgrade crossterm to 0.27
Migrate
crossterm
from version 0.24 to 0.27. No relevant breaking changes.fix(deps): upgrade rprompt to 2.1.1
Migrate
rprompt
from version 1 to 2.Code migration was applied, adapting
fastmod
torprompt
breaking API changes:https://github.com/conradkleinespel/rprompt/releases/tag/v2.0.2
feat(deps): upgrade clap from 2 to 4, migrating to clap derive
This changeset migrates
fastmod
from clap 2.x to the latest clap 4.x, migrating code around breaking changes.The arguments setup and retrieval is migrated to clap's much more maintainable
derive
syntax.All arguments are migrated to function identically to their clap 2 counterparts.
fix(deps): update grep from 0.2 to 0.3
Migrate
grep
from version 0.2 to 0.3. No relevant breaking changes. (grep-searcher
was upgraded from 0.1.7 to 0.2.1, but re-exportgrep::searcher
is unused infastmod
.)style: fix all clippy lints
Fixes all clippy lints, while not changing application behavior.
I will provide further patches updating direct crate dependencies.