Add async generator API to pywatchman_aio #1297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D80124350. (Because this pull request was imported automatically, there will not be any future comments.) |
|
@trevorm4 has updated the pull request. You must reimport the pull request before landing. |
|
@trevorm4 has updated the pull request. You must reimport the pull request before landing. |
Summary: Many of the other client libraries have event driven async APIs, but python does not really have that currently. The best it has is `get_subscription` which acts as a polling api as it directly returns `q.get()` instead of returning the queue itself. This diff adds an API to yield elements in the queue so that it can be used as an async generator to make the code more event driven. Test Plan: Aio has no tests currently, but open to suggestions! I have tested it locally in my own application but in reality the asyncio version should probably have its own tests and be published on Pypi, but that is out of the scope of this diff.
|
@trevorm4 has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Many of the other client libraries have event driven async APIs, but python does not really have that currently. The best it has is
get_subscriptionwhich acts as a polling api as it directly returnsq.get()instead of returning the queue itself.This diff adds an API to yield elements in the queue so that it can be used as an async generator to make the code more event driven.
Test Plan:
Aio has no tests currently, but open to suggestions!
I have tested it locally in my own application but in reality the asyncio version should probably have its own tests and be published on Pypi, but that is out of the scope of this diff.