[Remote Compaction] Additional debug logging for InputFileCheck Failure #13452
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaykorean
force-pushed
the
remote_compaction_more_debug_log
branch
from
a65ab98 to
bfe7ce8
Compare
jaykorean
force-pushed
the
remote_compaction_more_debug_log
branch
from
bfe7ce8 to
da8c54a
Compare
jaykorean
added a commit
to jaykorean/rocksdb
that referenced
this pull request
Mar 10, 2025
Summary: Add debug logging when the Wait() does not return `kSuccess` so that we can compare the version state that was printed by the logging added in facebook#13427 upon InputFileCheck failure. # Test Plan CI + Tested with Temporary Change in Meta Internal Infra Differential Revision: D70898832 Pulled By: jaykorean
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
reviewed
Mar 10, 2025
| @@ -110,6 +110,9 @@ CompactionJob::ProcessKeyValueCompactionWithCompactionService( | |||
| break; | |||
| } | |||
|
|
|||
| std::string debug_str_before_wait = | |||
| compaction->input_version()->DebugString(); | |||
There was a problem hiding this comment.
do we not need the hex=true here for printing the smallest key in the file etc
There was a problem hiding this comment.
We are only interested in the SST files in each input level. Basically the issue is that remote worker is not able to locate the input SST files in the vstorage. Key-level information is not needed for this purpose.
I am planning to remove this extra debug logging when we complete fixing the issue. (I can probably add TODO comment to remind myself :))
|
@jaykorean merged this pull request in 22ca6e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add debug logging when the Wait() does not return
kSuccessso that we can compare the version state that was printed by the logging added in #13427 upon InputFileCheck failure.Test Plan
CI + Tested with Temporary Change in Meta Internal Infra