Enable hardware accelerated crc32c for ARM on Linux #13432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D70423483 |
Nicoshev
force-pushed
the
export-D70423483
branch
from
d7d4a73 to
69c35bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70423483 |
Summary: We've noticed the default CRC32c function gets executed when running on aarch64 cpus within our servers Issue is that ROCKSDB_AUXV_GETAUXVAL_PRESENT evaluates to false This fix allows the usage of hardware-accelerated crc32 within our fleet Differential Revision: D70423483
Nicoshev
force-pushed
the
export-D70423483
branch
from
69c35bf to
adb23b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70423483 |
jaykorean
approved these changes
Mar 2, 2025
|
This pull request has been merged in 1d6c33d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We've noticed the default CRC32c function gets executed when running on aarch64 cpus within our servers
Issue is that ROCKSDB_AUXV_GETAUXVAL_PRESENT evaluates to false
This fix allows the usage of hardware-accelerated crc32 within our fleet
Differential Revision: D70423483