Fix mismatching BlockContents::has_trailer #12955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm304321141
changed the title
|
The PR summary is not clear to me what issue this PR is trying to solve. Can you provide a UT to demonstrate the expected behavior and existing behavior? |
Sorry I don't have time to build a case, please treat this PR as an issue It's not very important, just core dump when hits the problem on debug build. The code that may have problems has been pointed out, you should be able to deduce what the problem is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockFetcher::ReadBlockContents()
|-- ReadBlock()
|-- UncompressSerializedBlock()
|-- InsertUncompressedBlockToPersistentCacheIfNeeded()
for this code path, we insert a BlockContent into persistent cache .
the BlockContent is from UncompressSerializedBlock, it has no trailer
but at next call to BlockFetcher::ReadBlockContents()
we will get the BlockContent from TryGetUncompressBlockFromPersistentCache()
and it set the BlockContent::has_trailer to true ???