Skip to content

Commit

Permalink
Disable tiered storage + BlobDB stress test (#10699)
Browse files Browse the repository at this point in the history
Summary:
There're 2 knobs to disable blobdb, adding that.
Also print call stack when there's assert failure.

Pull Request resolved: #10699

Reviewed By: gitbw95

Differential Revision: D39596448

Pulled By: jay-zhuang

fbshipit-source-id: 5ce9fd0630d8b6ff1e157a2685a1e80a99997098
  • Loading branch information
jay-zhuang authored and facebook-github-bot committed Sep 19, 2022
1 parent 92df369 commit 00050d4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions db_stress_tool/db_stress.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ int main() {
return 1;
}
#else
#include "port/stack_trace.h"
#include "rocksdb/db_stress_tool.h"

int main(int argc, char** argv) {
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
return ROCKSDB_NAMESPACE::db_stress_tool(argc, argv);
}
#endif // GFLAGS
9 changes: 5 additions & 4 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ def is_direct_io_supported(dbname):
# endless compaction
"compaction_style": 1,
# tiered storage doesn't support blob db yet
"enable_blob_files": 0,
"use_blob_db": 0,
}

Expand Down Expand Up @@ -596,11 +597,11 @@ def gen_cmd_params(args):
if args.test_tiered_storage:
params.update(tiered_params)

# Best-effort recovery and BlobDB are currently incompatible. Test BE recovery
# if specified on the command line; otherwise, apply BlobDB related overrides
# with a 10% chance.
# Best-effort recovery, user defined timestamp, tiered storage are currently
# incompatible with BlobDB. Test BE recovery if specified on the command
# line; otherwise, apply BlobDB related overrides with a 10% chance.
if (not args.test_best_efforts_recovery and
not args.enable_ts and
not args.enable_ts and not args.test_tiered_storage and
random.choice([0] * 9 + [1]) == 1):
params.update(blob_params)

Expand Down

0 comments on commit 00050d4

Please sign in to comment.