Add dynamic flag to opt provided variables out of value memoization

compiler/crates/relay-typegen/src/write.rs

@@ -822,17 +822,26 @@ fn generate_provided_variables_type(
                 encountered_enums,
                 custom_scalars,
             )));
-            let provider_module = Prop::KeyValuePair(KeyValuePairProp {
+            let provider_get = Prop::KeyValuePair(KeyValuePairProp {
                 key: "get".intern(),
                 read_only: true,
                 optional: false,
                 value: provider_func,
             });
+            let provider_dynamic = Prop::KeyValuePair(KeyValuePairProp {
+                key: "dynamic".intern(),
+                read_only: true,
+                optional: true,
+                value: AST::Boolean,
+            });
             Some(Prop::KeyValuePair(KeyValuePairProp {
                 key: def.name.item.0,
                 read_only: true,
                 optional: false,
-                value: AST::ExactObject(ExactObject::new(vec![provider_module])),
+                value: AST::ExactObject(ExactObject::new(vec![
+                    provider_get,
+                    provider_dynamic,
+                ])),
             }))
         })
         .collect_vec();

compiler/crates/relay-typegen/tests/generate_flow/fixtures/query-mixed-provided-variables.expected

@@ -80,12 +80,15 @@ export type queryMixedProvidedVar_MultiFragment = {
   "__relay_internal__pv__skipFirstnameProvider": require('skipFirstnameProvider')
 } as {
   readonly __relay_internal__pv__includeNameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => CustomBoolean,
   },
   readonly __relay_internal__pv__numberOfFriendsProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => number,
   },
   readonly __relay_internal__pv__skipFirstnameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => CustomBoolean,
   },
 });
@@ -109,6 +112,7 @@ export type queryMixedProvidedVar_OneFragment = {
   "__relay_internal__pv__includeNameProvider": require('includeNameProvider')
 } as {
   readonly __relay_internal__pv__includeNameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => CustomBoolean,
   },
 });

compiler/crates/relay-typegen/tests/generate_flow/fixtures/query-only-provided-variables.expected

@@ -56,9 +56,11 @@ export type queryOnlyProvidedVar_MultiFragment = {
   "__relay_internal__pv__numberOfFriendsProvider": require('numberOfFriendsProvider')
 } as {
   readonly __relay_internal__pv__includeNameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => CustomBoolean,
   },
   readonly __relay_internal__pv__numberOfFriendsProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => number,
   },
 });
@@ -80,6 +82,7 @@ export type queryOnlyProvidedVar_OneFragment = {
   "__relay_internal__pv__includeNameProvider": require('includeNameProvider')
 } as {
   readonly __relay_internal__pv__includeNameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => CustomBoolean,
   },
 });

compiler/crates/relay-typegen/tests/generate_flow/fixtures/query-provided-variables-custom-scalar.expected

@@ -32,6 +32,7 @@ export type testQuery = {
   "__relay_internal__pv__includeNameProvider": require('includeNameProvider')
 } as {
   readonly __relay_internal__pv__includeNameProvider: {
+    readonly dynamic?: boolean,
     readonly get: () => ?JSON,
   },
 });

packages/relay-runtime/util/RelayConcreteNode.d.ts

@@ -112,9 +112,10 @@ export const RelayConcreteNode: {
 };
 
 export interface ProvidedVariablesType {
-    readonly [key: string]: { get(): unknown };
+    readonly [key: string]: ProvidedVariableType;
 }
 
 export interface ProvidedVariableType {
     get(): unknown;
+    readonly dynamic?: boolean;
 }

packages/relay-runtime/util/RelayConcreteNode.js

@@ -39,9 +39,14 @@ export type NormalizationRootNode =
   | ConcreteRequest
   | NormalizationSplitOperation;
 
-export type ProvidedVariableType = {get(): unknown};
+export type ProvidedVariableType = {
+  get(): unknown,
+  readonly dynamic?: boolean,
+};
 
-export type ProvidedVariablesType = {readonly [key: string]: {get(): unknown}};
+export type ProvidedVariablesType = {
+  readonly [key: string]: ProvidedVariableType,
+};
 
 /**
  * Contains the parameters required for executing a GraphQL request.