Skip to content

Conversation

@rickmark
Copy link

Redex produces libtool.so/dylib and libresource.so/dylib - When these are installed they are very likely to cause confusion as there is a standard binary called libtool. This patch changes these to be more appropriately libredexTool.so and libredexResource.so.

Also included is the FindRedex.cmake script from Mariana Trench that should be installed to allow for cmake style find_package(Redex)

@rickmark
Copy link
Author

#773

@facebook-github-bot
Copy link
Contributor

Hi @rickmark!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants