Skip to content

Bump chromium-edge-launcher to drop rimraf #54711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump chromium-edge-launcher to drop rimraf #54711

wants to merge 1 commit into from
+5 −6

Conversation

@kitten
Copy link
Contributor

@kitten kitten commented Nov 26, 2025 •
edited
Loading

Summary:

Related to #54669

This version bump drops rimraf.

This has been raised at a sync before, but it'd be great to instead drop or replace this entirly. I also noticed that it pulls in @types/node@*, which isn't necessary for it to function as well, and generally, it'd be nice if we had an alternative here.

cc @huntie

Changelog:

[GENERAL] [SECURITY] - Bump to chromium-edge-launcher@^0.3.0 to drop rimraf

Test Plan:

  • Package hasn't changed except for rimraf having been dropped

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2025
@facebook-github-bot facebook-github-bot added p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 26, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 27, 2025

@robhogan has imported this pull request. If you are a Meta employee, you can view this in D87978681.

cortinico
cortinico approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robhogan robhogan robhogan approved these changes

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kitten @robhogan @cortinico @facebook-github-bot