fix: RNGP trying to configure deleted generated CMake projects when executing cleaning task

[tjzel]

Summary:

I noticed that in Reanimated monorepo executing a clean task in an example app results in an error due to RNGP trying to configure codegen-generated CMake targets after they have been removed.

I think the error happens because configureReactNativeNdk is called on every task and it indiscriminately changes CMake configs in

react-native/packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/NdkConfiguratorUtils.kt

Lines 29 to 35 in 87a7796

	if (ext.externalNativeBuild.cmake.path == null) {
	ext.externalNativeBuild.cmake.path =
	File(
	extension.reactNativeDir.get().asFile,
	"ReactAndroid/cmake-utils/default-app-setup/CMakeLists.txt",
	)
	}

You can reproduce it with a brand new community CLI app:

1. npx @react-native-community/cli@latest init --skip-install --install-pods false --version 0.82 App82
2. cd App82
3. yarn
4. yarn add @react-native-community/clipboard` (or any other library with codegen)
5. Build the app in Android Studio
6. Use Build -> Clean Project in Android Studio.

Alternatively, after building, you can add the following anywhere in android/app/build/generated/autolinking/src/main/jni/Android-autolinking.cmake

message(FATAL_ERROR "Reading codegen CMakeLists.txt during cleanup")

I think that since the cleanup process can be parallelized add_subdirectory for codegen-generated CMakeLists.txt shouldn't be picked up in the cleaning task.

Changelog:

[ANDROID] [FIXED] - RNGP trying to configure deleted generated CMake projects when executing cleaning task

Test Plan:

Applying the fix in a brand-new community CLI app fixes the issue.

[cortinico]

I don't think this is the right fix sadly. This will have a cascading effect resulting in invalidating the configuration cache if you call ./gradlew clean, because you're effectively changing the build configuration.

I think the underlying problem is a different one. There either a wrong task dependency, or we're cleaning too many things during ./gradlew clean.

I'll dm you to follow up the conversation as I think it's worth some investigation here