Extract TurboModuleManager from ReactHost #54651
Closed
+184
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
javache
force-pushed
the
export-D87774276
branch
from
882b3e5 to
3c8f292
Compare
Chandramuhilan
left a comment
Chandramuhilan
left a comment
There was a problem hiding this comment.
🤖 Automated PR Review
PR: Extract TurboModuleManager from ReactHost
Files Changed: 5
Lines: +184 -110
Pattern-Based Analysis
Total Issues Found: 355
⚠️ High Priority (118)
- Line 2: Potential division by zero - add zero check
- Line 2: Potential division by zero - add zero check
- Line 2: Potential division by zero - add zero check
- Line 2: Potential division by zero - add zero check
- Line 2: Potential division by zero - add zero check
ℹ️ Medium Priority (12)
- Line 61: Weak cryptographic algorithm - use SHA-256 or better
- Line 126: Weak cryptographic algorithm - use SHA-256 or better
- Line 127: Weak cryptographic algorithm - use SHA-256 or better
Generated by PR Review Agent
Summary: Break up ReactHost and TurboModuleManager, so in the future we can inject this more easily. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D87774276
javache
force-pushed
the
export-D87774276
branch
from
3c8f292 to
cbf10a9
Compare
|
This pull request has been merged in 1493a0a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up ReactHost and TurboModuleManager, so in the future we can inject this more easily.
Changelog: [Internal]
Differential Revision: D87774276