Make yoga/Yoga.h an umbrell header #52817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78692457 |
rudybear
added a commit
to rudybear/yoga
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/react-native#52817 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
rudybear
added a commit
to rudybear/litho
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/react-native#52817 X-link: facebook/yoga#1828 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
rudybear
force-pushed
the
export-D78692457
branch
from
b1bac22 to
395d77c
Compare
rudybear
added a commit
to rudybear/react-native
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/yoga#1828 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
Summary: Pull Request resolved: facebook#52817 X-link: facebook/yoga#1828 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
rudybear
added a commit
to rudybear/yoga
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/react-native#52817 Pull Request resolved: facebook#1828 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
rudybear
added a commit
to rudybear/litho
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/react-native#52817 X-link: facebook/yoga#1828 Pull Request resolved: facebook#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78692457 |
rudybear
force-pushed
the
export-D78692457
branch
from
395d77c to
6ddf035
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jul 24, 2025
Summary: X-link: facebook/react-native#52817 Pull Request resolved: #1828 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457 fbshipit-source-id: 7fcd53d2a6f268fa4377dbd5bd6ba6eebc94b5f8
Contributor
|
This pull request has been merged in 8ed2cee. |
Collaborator
|
This pull request was successfully merged by @rudybear in 8ed2cee When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebook#52817 X-link: facebook/yoga#1828 X-link: facebook/litho#1070 This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457 fbshipit-source-id: 7fcd53d2a6f268fa4377dbd5bd6ba6eebc94b5f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1828
X-link: facebook/litho#1070
This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header.
Changelog:
[General][Added] - Code quality fixes
Reviewed By: corporateshark
Differential Revision: D78692457