Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdefs: add typings for node's built-in Module module #8540

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gorakong
Copy link

Derived from the documentation and source code of Module:

@Brianzchen
Copy link
Contributor

Hi @gorakong. Can you please also update the test files. To do this, you need to setup and run the test suite and then update the exp with the out file that's generated.

lib/node.js Outdated Show resolved Hide resolved
@gorakong
Copy link
Author

hey @Brianzchen, i've updated the test files 🙂

@Brianzchen
Copy link
Contributor

@gorakong your changes have updated enums.exp, get_def_enums.exp, node_tests.exp. You'll need to update them locally then push new exp files

@gorakong
Copy link
Author

@Brianzchen gotcha. added!

@nmote nmote added the Library definitions Issues or pull requests about core library definitions label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants