[Nexthop][run_scripts] Fix systemctl enable failure with SELinux enforcing#1321
Open
zackary-nexthop wants to merge 1 commit into
Open
[Nexthop][run_scripts] Fix systemctl enable failure with SELinux enforcing#1321zackary-nexthop wants to merge 1 commit into
zackary-nexthop wants to merge 1 commit into
Conversation
…rcing Signed-off-by: Zackary Ayoun <zackary@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Write qsfp/fsdb OSS service unit files to
/run/systemd/system/instead of/tmp/.Files in
/tmp/carry thetmp_tSELinux label. On CentOS Stream 9 with SELinux in enforcing mode,systemctl enable /tmp/*.servicefails because the policy blocks symlinking from/etc/systemd/system/totmp_ttargets. The existing enable/disable lifecycle is otherwise correct./run/systemd/system/is the systemd-designated directory for dynamically-generated, non-persistent unit files. Files written there inheritsystemd_unit_file_tautomatically, sosystemctl enableworks without any label manipulation. Files are cleaned up on reboot, matching the transient nature of test services.Changed files:
services/qsfp_service_utils.py:_QSFP_SERVICE_UNIT_FILE_PATH/tmp/->/run/systemd/system/services/fsdb_service_utils.py:_FSDB_SERVICE_UNIT_FILE_PATH/tmp/->/run/systemd/system/Test plan
systemctl enable/disablesucceed, link tests pass.