Skip to content

Update Node.js & NPM versions used in the plugin #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

iodic
Copy link
Collaborator

@iodic iodic commented Jun 13, 2025

Description

This changeset bumps the Node version used in the plugin tooling to version 22. (The constraints are set to versions between 22 and 24.) It also bumps NPM to version 10 or higher.

The NVM config file is also updated to use version 22 for easier version switching.

Moving forward, we will be able to keep packages up to date incrementally, without big bumps like here.

Type of change

  • Fix (non-breaking change which fixes an issue)

Checklist

  • I have commented my code, particularly in hard-to-understand areas, if any.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [n/a] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • [n/a] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Update Node.js & NPM versions used in the plugin

Test Plan

  • Please update your local Node version to 22 and run npm install.
  • Test all of the scripts defined in package.json.
  • Build the release artifact and install on a test site. Test the website to monitor event tracking and test admin features (catalog syncing, ad view,…).

@iodic
Copy link
Collaborator Author

iodic commented Jun 13, 2025

P.S. Once the PR is approved, we will have to update the GH build pipeline to run on new Node versions.

@iodic
Copy link
Collaborator Author

iodic commented Jun 13, 2025

@vinkmeta, can you test these changes on your machine and also on a test website? Please report if you encounter any issues.

Copy link
Contributor

@vahidkay-meta vahidkay-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these warnings when I run npm install. Can't we get rid of them?

npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

@iodic
Copy link
Collaborator Author

iodic commented Jun 26, 2025

I see these warnings when I run npm install. Can't we get rid of them?

npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

I think that some were locked as dependencies; we are checking if an update is feasible. I agree that it is annoying to see those warnings.

@iodic iodic force-pushed the chore/node-npm-update branch from d3d35d3 to f1d0512 Compare June 27, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants