Storybook: add the missing Probe Theme all-axes page - #5570
Merged
Conversation
The probe theme was selectable in the toolbar but had no Storybook page of its own, so there was no surface where someone could inspect what it actually does. The existing Core/Themes group contained implementation demos only — no icons, indicators, tokens, syntax, or probe page. Core/Themes/Probe Theme now puts all six defineTheme axes on one switchable surface: component targets, token swatches, semantic icon swaps, checkbox/radio indicator swaps, typography, and syntax highlighting. It deliberately does NOT wrap itself in <Theme>; the toolbar and visual gate own the active theme, so Neutral and Probe can be compared honestly. The capture asserts the theme applied and counted 9 icon replacements + 3 indicator replacements under Probe, versus zero markers under Neutral.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
commented
Aug 26, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks — relabel's right, six axes still check out.
Body screenshots are pre-fix ("Switch indicator"); Token Inspector and CodeTheme already cover tokens and syntax; 91.37% should be ~96%.
Refresh and merge?
[Reviewed by Robohands]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Probe theme has been selectable in Storybook since #5396, but there is no useful Theme section where someone can see it.
Core/Themescontains four implementation demos; none covers tokens, icons, indicators, fonts, syntax, or the probe fixture.What
Adds
Core/Themes/Probe Theme:defineThemeaxesIt deliberately does not wrap itself in
<Theme>: the toolbar and visual gate own the active theme, so Neutral ↔ Probe switching is honest. The capture asserts which theme applied; Probe rendered 9 icon replacements + 3 indicator replacements, Neutral rendered zero markers.Risk
Storybook-only. No component, API, or package behavior changes. No changeset.
Testing
pnpm -F @astryxdesign/storybook typecheckpnpm -F @astryxdesign/storybook buildVisual evidence
Before — Neutral
After — Probe
Pixel diff
1,320,346 pixels changed (91.37%). The capture also asserts the active theme: Probe rendered 9 marked icon replacements and 3 marked indicator replacements; Neutral rendered none.